From: Alejandro PiƱeiro Date: Wed, 24 Oct 2012 17:29:07 +0000 (+0200) Subject: a11y: fixing a regression with the accessible name at dash items X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5484 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4ebf396cf5b34eea72c930e340b47bb539809d0e;p=gnome-shell.git a11y: fixing a regression with the accessible name at dash items After some changes, the tooltip label at the dash is not available until it is visually shown. As this is not anymore a reliable source of accessible name, we just set the accessible name with the string used on that label. https://bugzilla.gnome.org/show_bug.cgi?id=686583 --- diff --git a/js/ui/dash.js b/js/ui/dash.js index b564aea8c..e1ad32145 100644 --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -142,6 +142,7 @@ const DashItemContainer = new Lang.Class({ setLabelText: function(text) { this._labelText = text; + this.child.accessible_name = text; }, hideLabel: function () { @@ -259,7 +260,6 @@ const ShowAppsIcon = new Lang.Class({ this.setChild(this.toggleButton); this.setDragApp(null); - this.toggleButton.label_actor = this.label; }, _createIcon: function(size) { @@ -507,9 +507,11 @@ const Dash = new Lang.Class({ let item = new DashItemContainer(); item.setChild(display.actor); + // Override default AppWellIcon label_actor, now the + // accessible_name is set at DashItemContainer.setLabelText + display.actor.label_actor = null; item.setLabelText(app.get_name()); - // Override default AppWellIcon label_actor - display.actor.label_actor = item.label; + display.icon.setIconSize(this.iconSize); this._hookUpLabel(item);